Skip to content

gh-94438: in frameobject's mark_stacks switch, the PUSH_EXC_INFO and POP_EXCEPT cases are no longer reachable#94582

Merged
iritkatriel merged 2 commits intopython:mainfrom
iritkatriel:setlineno
Jul 6, 2022
Merged

gh-94438: in frameobject's mark_stacks switch, the PUSH_EXC_INFO and POP_EXCEPT cases are no longer reachable#94582
iritkatriel merged 2 commits intopython:mainfrom
iritkatriel:setlineno

Conversation

@iritkatriel
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel commented Jul 5, 2022 •
edited by bedevere-bot
Loading

@iritkatriel
pythongh-94438: in frameobject's mark_stacks switch, the PUSH_EXC_INF…
9efd9e0 
…O and POP_EXCEPT cases are no longer reachable
@iritkatriel iritkatriel requested a review from markshannon as a code owner July 5, 2022 18:52
@iritkatriel iritkatriel mentioned this pull request Jul 5, 2022
Closed
3 tasks
mdboom
mdboom reviewed Jul 5, 2022
View reviewed changes
Comment thread Objects/frameobject.c
@iritkatriel iritkatriel requested a review from pablogsal July 5, 2022 19:14
@sweeneyde
Copy link
Copy Markdown
Member

sweeneyde commented Jul 5, 2022

Maybe this is already understood, but stacks remaining UNINITIALIZED seems to be the cause of #92228

tiran
tiran approved these changes Jul 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritkatriel
Copy link
Copy Markdown
Member Author

iritkatriel commented Jul 5, 2022

Maybe this is already understood, but stacks remaining UNINITIALIZED seems to be the cause of #92228

I wasn't aware of this, I'll have a look thanks.

@iritkatriel iritkatriel merged commit 50b9a77 into python:main Jul 6, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 6, 2022

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 6, 2022

Sorry @iritkatriel, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 50b9a7762f06335277d9962edc8d39498601a4e4 3.11

@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jul 6, 2022
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Jul 6, 2022
@iritkatriel
[3.11] pythongh-94438: in frameobject's mark_stacks switch, the PUSH_…
f2df71b 
…EXC_INFO and POP_EXCEPT cases are no longer reachable (pythonGH-94582)

(cherry picked from commit 50b9a77)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 6, 2022
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 6, 2022

GH-94595 is a backport of this pull request to the 3.11 branch.

iritkatriel added a commit that referenced this pull request Jul 6, 2022
@iritkatriel
[3.11] gh-94438: in frameobject's mark_stacks switch, the PUSH_EXC_IN…
b22f9d6 
…FO and POP_EXCEPT cases are no longer reachable (GH-94582) (GH-94595)

(cherry picked from commit 50b9a77)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatriel iritkatriel deleted the setlineno branch September 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom mdboom left review comments

@tiran tiran tiran approved these changes

@pablogsal pablogsal pablogsal approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@iritkatriel iritkatriel

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@iritkatriel @sweeneyde @miss-islington @bedevere-bot @mdboom @tiran @pablogsal